Skip to content

cleanup WiFiUdp virtual override decorators - add virtual destructor #5637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2019
Merged

cleanup WiFiUdp virtual override decorators - add virtual destructor #5637

merged 1 commit into from
Jan 19, 2019

Conversation

liebman
Copy link
Contributor

@liebman liebman commented Jan 19, 2019

Per #1557

@liebman
decorate as override virtual methods in WiFiUDP
04bede6 
make WiFiUDP destructor virtual
add empty virtual destructor to Udp
earlephilhower
earlephilhower approved these changes Jan 19, 2019
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earlephilhower earlephilhower added this to the 2.5.0 milestone Jan 19, 2019
@d-a-v d-a-v merged commit 049a9ea into esp8266:master Jan 19, 2019
@d-a-v d-a-v mentioned this pull request Jan 19, 2019
Closed
@liebman liebman deleted the cleanup-virtual-override-decorators branch September 10, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@liebman @earlephilhower @d-a-v